refactor: e2e test#1094
Open
XMLHexagram wants to merge 9 commits intomasterfrom
Open
Conversation
Owner
|
Thanks! the PR is large, and I’ll take some time to review it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is aimed to improve e2e test, related to #1079.
I referenced @ernado's reply in tdlib/td#3083 when implemented this PR.
In this PR, I switch e2e test from server teamgram to telegram official server.
Currently, the account data for e2e testing is exported from a vacant account.
Let me explain how it works.
First, the account credentials used in e2e testing can be exported from
tools/export_credentials. These credentials are then stored in the GitHub Environment Secrets. For example, the e2e action now automatically reads theTG_CREDENTIALSvariable from theMainenvironment and uses it for testing.Finally, owner and maintainers can start e2e testing by commenting
/e2ein a PR or by manually triggering the process.BTW, I set a 3min timeout and 1s interval on e2e test, to reduce rate limit.
I already test this PR in my fork, please check XMLHexagram#2.
If needed, I can provide an account for testing in tdl.